]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
SQUASH: client: querying for stx_version field requires getting all shared caps
authorJeff Layton <jlayton@redhat.com>
Thu, 1 Sep 2016 22:49:46 +0000 (18:49 -0400)
committerJeff Layton <jlayton@redhat.com>
Thu, 1 Sep 2016 22:49:46 +0000 (18:49 -0400)
commit821e77cf1da59b9dcf3517101dc8b923e5358960
treead84eef7c9222c2b4b8fdd69ca039929a73d79aa
parent44b102f9e2e2acb854899903557068482afdf0fa
SQUASH: client: querying for stx_version field requires getting all shared caps

Otherwise, someone could potentially query for just CEPH_STATX_VERSION,
and see it as unchanged, even when there are changes buffered up on
other clients.

By doing this, I don't think we'll incur any perf hit in the common use
case which is ganesha querying for all attributes. We are adding Xs
here, but unless there is a lot of xattr activity I don't think that
will generally cause a lot of exclusive cap recalls.

Also, we don't actually need AUTH caps to fetch CEPH_STATX_RDEV, remove
that from statx_to_mask. PIN is sufficient there.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
src/client/Client.cc