]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crimson/osd, seastore: fix log argument mismatches in error paths
authorKefu Chai <k.chai@proxmox.com>
Tue, 16 Jun 2026 12:34:05 +0000 (20:34 +0800)
committerKefu Chai <k.chai@proxmox.com>
Wed, 17 Jun 2026 08:54:51 +0000 (16:54 +0800)
commit863f65fdee51c02812257aeb8bfc6771b379c29d
tree29236a2a74a714777a8ae73dbd2d2798a30eb3ac
parent846f9294c6ee5b13ed0194a9fabea79023ec0549
crimson/osd, seastore: fix log argument mismatches in error paths

two log calls in errorator continuations were missing an argument. the
compile-time fmt check surfaced these as a confusing "call to immediate
function ... is not a constant expression" deep in the errorator/composer
machinery rather than a plain "too few arguments", because the consteval
format failure escalates through the continuation templates:

- shard_services.cc handle_pg_create_info(): "ignore pgid {}" never
  passed pgid.
- node.cc: the read_extent error handler logged "{} -- addr={},
  is_level_tail={}" without the leading error; pass the std::error_code
  and include <fmt/std.h> for its formatter.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
src/crimson/os/seastore/onode_manager/staged-fltree/node.cc
src/crimson/osd/shard_services.cc