]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mon/Paxos: update first_committed when we trim
authorSage Weil <sage@inktank.com>
Wed, 1 May 2013 17:57:35 +0000 (10:57 -0700)
committerSage Weil <sage@inktank.com>
Wed, 1 May 2013 17:57:58 +0000 (10:57 -0700)
commit88c030fc05dcc5227ec1b3e32e9169312d640ac1
tree3b66554c657f3b2f7790347abf3d734562f01d71
parent3a6138b25ed38d7e55c85b997fb8533e97e63c68
mon/Paxos: update first_committed when we trim

The Paxos::trim() -> ::trim_to() path trims old states but does not
update first_committed.  This misinforms later paxos rounds such that
peers think they can participate and end up with COMMIT messages
following the COLLECT/LAST exchange that are for future commits they
can't do anything with and then crash out when they get the BEGIN:

mon/Paxos.cc: 557: FAILED assert(begin->last_committed == last_committed)

Fixes: #4879
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
src/mon/Paxos.cc