]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
cls/rgw: preserve olh entry's name on last unlink 37462/head
authorCasey Bodley <cbodley@redhat.com>
Fri, 10 Jul 2020 16:38:06 +0000 (12:38 -0400)
committerNathan Cutler <ncutler@suse.com>
Tue, 29 Sep 2020 15:55:04 +0000 (17:55 +0200)
commit8b20dd75b6261ce87bbb55a06e4fe38ff3e802de
treed658a5001f409fad4ecd6f35cf1e77947f347245
parenta3363c736f9076fa329a9aaff25ea82b817b5115
cls/rgw: preserve olh entry's name on last unlink

When rgw_bucket_unlink_instance removes the last instance of a name, it
also clears the value of rgw_bucket_olh_entry.key. However, bucket index
resharding uses this key when choosing its shard placement, so an empty
key causes all of these olh entries to be misplaced in shard 0. After
reshard, all of the olh recovery/cleanup logic would be sent to the
correct shard, and these misplaced olh entries would never be cleaned
up.

Preserving the key's name on last unlink allows the olh entry to be
resharded correctly and cleaned up normally.

Fixes: https://tracker.ceph.com/issues/46456
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit acf8f3cad9f55e34c703fdaef684853a3fb3b369)
src/cls/rgw/cls_rgw.cc