]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
qa/vstart_runner: don't let command run after timeout
authorRishabh Dave <ridave@redhat.com>
Wed, 3 Apr 2024 05:41:29 +0000 (11:11 +0530)
committerRishabh Dave <ridave@redhat.com>
Wed, 17 Apr 2024 04:39:59 +0000 (10:09 +0530)
commit8bc23e50df7b2f4ee4792271a2aad43614caf00f
tree2b1568029ed2453d6f30312af9d036834a300d5c
parent639d182732644edc5c413562ebc904ab5b953303
qa/vstart_runner: don't let command run after timeout

Parameter "timeout" is accepted by LocalRemote.run() but the method
doesn't do anything about it besides accepting it. Thus, this parameter
has no effect.

In LocalRemote.run(), pass this parameter to LocalRemoteProcess.wait()
and from this method pass it to subprocess.Popen.communicate(). Thus,
command will be terminated by subprocess module at seconds specified by
"timeout" parameter. IOW, "timeout" parameter will have an effect.

Fixes: https://tracker.ceph.com/issues/65533
Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/vstart_runner.py