]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
ReplicatedPG::fill_in_copy_get: fix early return bug
authorSamuel Just <sam.just@inktank.com>
Tue, 4 Mar 2014 23:21:09 +0000 (15:21 -0800)
committerSamuel Just <sam.just@inktank.com>
Wed, 5 Mar 2014 03:23:00 +0000 (19:23 -0800)
commit8fdfece9fd5419eeb1bc65b3ac4987f6e150fd9f
treedcbcdc0adf89ed39e3992bf8ba5ab16f33710a94
parent4bf28df22908f7be4949cbc7ec36e3060d96ca5c
ReplicatedPG::fill_in_copy_get: fix early return bug

This is not a leak: we are in an else block where cb must
be NULL.  The fix as introduced did not include braces on
the if causing the method to return unconditionally.

Fixes: #7604
Introduced in: 500206d809f0cd85cd99e4f0ec164bbf74f92c28
Reviewed-by: David Zafman <david.zafman@inktank.com>
Signed-off-by: Samuel Just <sam.just@inktank.com>
src/osd/ReplicatedPG.cc