]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
erasure-code: refactor the interfaces to hide internals from public
authorKefu Chai <kchai@redhat.com>
Thu, 2 Nov 2017 09:15:00 +0000 (17:15 +0800)
committerKefu Chai <kchai@redhat.com>
Fri, 3 Nov 2017 08:16:46 +0000 (16:16 +0800)
commit902f5508b8b0bf7b75672afd9ef9fb7bdaff51c4
treefd10f639d1612f4384bc2f66543709710741d950
parent3c528845f63782bb49dcd112550a894b93e8097a
erasure-code: refactor the interfaces to hide internals from public

after the arraycode change, the old encode() and minimum_to_decode() are
actually replaced by the new counterparts, and are only used by the
ErasureCode itself. so they can be marked `private`, but the unittests
are still using them heavily. so they are kept `public`. and to avoid the
`-Woverloaded-virtual` warnings, because the new methods share the same
names with the old ones. a underscore is used as the prefix of the
internal methods.

Signed-off-by: Kefu Chai <kchai@redhat.com>
15 files changed:
src/erasure-code/ErasureCode.cc
src/erasure-code/ErasureCode.h
src/erasure-code/lrc/ErasureCodeLrc.cc
src/erasure-code/lrc/ErasureCodeLrc.h
src/erasure-code/shec/ErasureCodeShec.cc
src/erasure-code/shec/ErasureCodeShec.h
src/test/erasure-code/ErasureCodeExample.h
src/test/erasure-code/TestErasureCodeExample.cc
src/test/erasure-code/TestErasureCodeIsa.cc
src/test/erasure-code/TestErasureCodeJerasure.cc
src/test/erasure-code/TestErasureCodeLrc.cc
src/test/erasure-code/TestErasureCodeShec.cc
src/test/erasure-code/TestErasureCodeShec_all.cc
src/test/erasure-code/TestErasureCodeShec_arguments.cc
src/test/erasure-code/TestErasureCodeShec_thread.cc