]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
test/librados_test_stub: unbreak selfmanaged_snap_rollback()
authorIlya Dryomov <idryomov@gmail.com>
Sun, 16 Jun 2024 18:40:31 +0000 (20:40 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Sun, 16 Jun 2024 22:16:14 +0000 (00:16 +0200)
commit91a06323549c3c68aa56e79fec21d6a7dcb62cc9
treeabb86b85ff6e046032dbda73319d54cbe00852ff
parentb3977c53c930100310868096408ad059dc5cad9b
test/librados_test_stub: unbreak selfmanaged_snap_rollback()

After the rollback assert in TestGroup.add_snapshot{,PP} was made
meaningful in the previous commit, it fails in mock tests which means
that rollback has never been exercised properly...

While I confess to not following file->snap_id == CEPH_NOSNAP branch
especially given how file variable is shadowed, it's pretty clear that
get_snap_read() doesn't belong here -- the snapshot selected for reads
has nothing to do with rollback.  Replacing it with the rollback snap
ID makes sense of the other branches and makes the tests in question
pass.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/test/librados_test_stub/TestMemIoCtxImpl.cc