]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
erasure-code: do not hide overloaded ErasureCode::parse() 5149/head
authorKefu Chai <kchai@redhat.com>
Mon, 6 Jul 2015 04:53:59 +0000 (12:53 +0800)
committerKefu Chai <kchai@redhat.com>
Mon, 6 Jul 2015 09:29:19 +0000 (17:29 +0800)
commit9760c220b80c79f61819d683b36114a1f46f18f6
treed613c468bb294b2ee70840e98e01b1b01a5fb724
parent5c6075f2e073d04190caf4c69c1042c3cbae6863
erasure-code: do not hide overloaded ErasureCode::parse()

* this change fixes the warning from clang:
  ErasureCodeJerasure::parse' hides overloaded virtual function
  [-Woverloaded-virtual]
* some erasure codecs' ErasureCode::parse() rewrites the profile
  using the default values when parsing it if the corresponding
  items are not specified. and we don't call ErasureCode::parse()
  via its children's references. so no need to make it a virtual
  function.
* and ErasureCode::parse() is used as a helper function by its
  children, so make it `protected`
* and parse() in ErasureCode's children is but a helper function
  called by ctor, descendants' parse() and init(). so make them
  protected or private accordingly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/erasure-code/ErasureCode.h
src/erasure-code/isa/ErasureCodeIsa.h
src/erasure-code/jerasure/ErasureCodeJerasure.h
src/erasure-code/shec/ErasureCodeShec.h