]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b550112) | patch
osd: don't write transaction when inc crc failed
authorDan van der Ster <daniel.vanderster@cern.ch>
Mon, 27 Jul 2020 15:40:27 +0000 (17:40 +0200)
committerDan van der Ster <daniel.vanderster@cern.ch>
Tue, 28 Jul 2020 21:15:42 +0000 (23:15 +0200)
commit99463cb523949289384a6210ea250114fbe852f4
treec1813711e26c7fb5efbae03d1e9006fa7b8ff910tree | snapshot
parentb550112dba23528655ec150cf9d6d093318abb8ccommit | diff
osd: don't write transaction when inc crc failed

80da5f9a987c6a48b93f25228fdac85890013520 exposed a flaw in how
handle_osd_map falls back to a full osdmap if the crc of an incremental
failed.

If the first message in a map message had a crc error, then the
loop would exit with last < start, which would then cause a null
dereference in _committed_osd_maps.

Fixes: https://tracker.ceph.com/issues/46443
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
src/osd/OSD.cc diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.