]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
run-make-check: fix do_cmake not consuming run-make-check opts 42842/head
authorDeepika Upadhyay <dupadhya@redhat.com>
Thu, 19 Aug 2021 09:00:33 +0000 (14:30 +0530)
committerDeepika Upadhyay <dupadhya@redhat.com>
Thu, 19 Aug 2021 12:58:56 +0000 (18:28 +0530)
commit9baf075c9f98f94b93045859250c23a11a07c03a
tree8de998cdd1ef92bb83615f9fa3bce378b911cda6
parentf74b748a423bdc754b15040b9d951806f4b316ee
run-make-check: fix do_cmake not consuming run-make-check opts

run-make-check.sh uses run-make.sh to `prepare`(install dependencies)
and `configure` cmake options, without quotes these options containing
special characters(hypens mostly) are skipped, hence we see not all
options supplied at cmake configure step.

Resolves(focused to solve issues in jenkins build env):
 - missing cmake options:
    cmake_opts+=" -DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler"
    cmake_opts+=" -DCMAKE_CXX_FLAGS_DEBUG=\-Werror"
 - Ninja not being used as cmake generator

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
run-make-check.sh