]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: Speed improvements of pool details 36392/head
authorStephan Müller <smueller@suse.com>
Thu, 10 Sep 2020 12:28:47 +0000 (14:28 +0200)
committerStephan Müller <smueller@suse.com>
Tue, 29 Sep 2020 08:59:21 +0000 (10:59 +0200)
commit9e0db83b810da7390bf6d9264039b900977f2d6e
tree88e5f070dd68b2ca426173b69337eb4aa9d09149
parent58653523872ae0b69ba474de4fa6c1bfaea4cc69
mgr/dashboard: Speed improvements of pool details

Now all variables that are shown in a listing that trigger a
more complex render cycle will only be updated if pool properties have
changed and not only the time series data, which isn't shown anymore,
as it can be seen graphically enhanced in the pool listing.

The pool detail component now uses the `onPush` change detection
strategy, to only call `ngOnChanges` if one of the input variables
have changed.

The function that only updates variables if they have changed is
now available through a helper class in order to provide this
useful functionality through out the dashboard.

Fixes: https://tracker.ceph.com/issues/46375
Signed-off-by: Stephan Müller <smueller@suse.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-details/pool-details.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-details/pool-details.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-details/pool-details.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/classes/cd-helper.class.spec.ts [new file with mode: 0644]
src/pybind/mgr/dashboard/frontend/src/app/shared/classes/cd-helper.class.ts [new file with mode: 0644]
src/pybind/mgr/dashboard/frontend/src/testing/unit-test-helper.ts