]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch 45412/head
authorCory Snyder <csnyder@iland.com>
Wed, 2 Feb 2022 09:46:59 +0000 (04:46 -0500)
committerCory Snyder <csnyder@iland.com>
Wed, 16 Mar 2022 10:36:53 +0000 (06:36 -0400)
commita0148ec08480ce585548393c39ddc291fe453727
tree628efa60838cec2252519d571de2e5ba0e2b517e
parent065c9d29f7426c283cf80fed433ed59efc43fe5e
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch

Fixes a segfault that was occuring in error handling code of UserAsyncRefreshHandler::init_fetch.
When ruser->read_stats_async returned an error code, the instance of UserAsyncRefreshHandler had
already been deallocated in RGWSI_User_RADOS::read_stats_async and a segmentation fault occurs
when attempting to print a member variable in error logs. This commit removes the extra ref count
drop since the ref is properly dropped upstream in RGWQuotaCache::async_refresh error handling
logic.

Fixes: https://tracker.ceph.com/issues/54112
Signed-off-by: Cory Snyder <csnyder@iland.com>
(cherry picked from commit 71ef3af870e5789e71480682f11a883ff3a673e7)
src/rgw/services/svc_user_rados.cc