]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
tests: prevent kill race condition 1960/head
authorLoic Dachary <loic@dachary.org>
Fri, 13 Jun 2014 12:41:39 +0000 (14:41 +0200)
committerLoic Dachary <loic@dachary.org>
Fri, 13 Jun 2014 12:46:42 +0000 (14:46 +0200)
commita1c13c57ba20fc329d943ea57523913e11067dc7
tree42b9da7c0b7cd8555a974de309eb49603a359758
parent1781e7f11d63d07babc187d3c6fe24c435f4a95b
tests: prevent kill race condition

When trying to kill a daemon, keep its pid in a variable instead of
retrieving it from the pidfile multiple times. It prevents the following
race condition:

  * try to kill ceph-mon
  * ceph-mon is in the process of dying and removed its pidfile
  * try to kill ceph-mon fails because the pidfile is not found
  * another ceph-mon is spawned and fails to bind the port
    because the previous ceph-mon is still holding it

Signed-off-by: Loic Dachary <loic@dachary.org>
src/test/ceph-disk.sh
src/test/mon/mkfs.sh
src/test/mon/mon-test-helpers.sh