]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests
authorMatan Breizman <mbreizma@redhat.com>
Mon, 12 May 2025 11:14:47 +0000 (11:14 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Mon, 12 May 2025 11:20:47 +0000 (11:20 +0000)
commita2121ebbc8ab7b41f0ffcd724b46ab778aa54efa
treeb293d6192d2ee2a7d95160cac81c955df83854da
parentf54e6e2c324435b2ca2ee05635c722e2ea851672
crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests

Before this patch, we would first send the MOSDPGUpdateLogMissing to
all peers and only then insert this rep_tid to log_entry_update_waiting_on.

This could have resulted in race where we receive the reply prior to
actually inserting the rep_tid.
The reply would have been discarded with "reply on unknown tid" (which
is now aborting).
The unhandled reply would have not let submit_error to return and would
keep holding the lock on this obc.

Fixes: https://tracker.ceph.com/issues/71204
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/osd/pg.cc