]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
ceph-volume: quick fix in zap.py 50745/head
authorGuillaume Abrioux <gabrioux@ibm.com>
Wed, 29 Mar 2023 14:58:11 +0000 (16:58 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 12 Apr 2023 19:42:03 +0000 (21:42 +0200)
commita666f700f16937565484dffc90713f6c04d76313
treedc8e200d0e02802d32c1c871a405974bd785ff37
parent34fc77ad585ad35dd6c0bbeea53b6fcd6b741571
ceph-volume: quick fix in zap.py

`api.get_single_pv(filters={'lv_uuid': lv.lv_uuid})` needs to be called
only if `--destroy` is passed in order to remove vg and pv when there's
nothing left.

With old deployments, it is possible that a lv_uuid matches more than 1
PV.
Given that `get_single_pv()` is only needed when `--destroy` is passed,
let's move this call where it is actually needed.

This makes `ceph-volume lvm zap` fail even though

Fixes: https://tracker.ceph.com/issues/59210
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
src/ceph-volume/ceph_volume/devices/lvm/zap.py