]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
ceph-volume: fix a bug in _check_generic_reject_reasons
authorKim Minjong <make.dirty.code@gmail.com>
Fri, 3 Feb 2023 02:47:47 +0000 (11:47 +0900)
committerKonstantin Shalygin <k0ste@k0ste.ru>
Wed, 29 Nov 2023 11:46:07 +0000 (18:46 +0700)
commita6a115dee87f9d8fede9f6bccde4b3fce30d1779
tree0aeed44f8c3d48dc5fc0e937aa6cf6dfc5928db0
parent3c13da14753780121385c386a2c49a3267372426
ceph-volume: fix a bug in _check_generic_reject_reasons

The types of removable and ro are wrong. Here, both filters are not
working at all. Changed this from integer to string and corrected the test
data.

Delete redundant logic in get_block_devs_sysfs. Given the name of the
function, I think it is correct to judge from _check_generic_reject_reasons,
and in fact it was before v17.2.4.

Fixes: https://tracker.ceph.com/issues/58591
Signed-off-by: Kim Minjong <make.dirty.code@gmail.com>
(cherry picked from commit a78e660728c6c0442cdbfa65db776b5856aee933)
src/ceph-volume/ceph_volume/tests/util/test_device.py
src/ceph-volume/ceph_volume/util/device.py
src/ceph-volume/ceph_volume/util/disk.py