]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: fix custom alertmanager webhooks 59889/head
authorAdam King <adking@redhat.com>
Thu, 19 Sep 2024 20:40:20 +0000 (16:40 -0400)
committerAdam King <adking@redhat.com>
Mon, 5 May 2025 19:21:26 +0000 (15:21 -0400)
commita8498ddad536305cdeda4699932dc4de7a93f540
tree0679cb557e8c7fc983244b9761060a58dc550a5a
parentf733a87f4d8f08ce15c541ff6e06a905772b323f
mgr/cephadm: fix custom alertmanager webhooks

Previously, we put the custom webhooks in the "default"
receiver. This didn't actually work as alertmanager only sends
alerts to the default receiver if the alert does not match
the following routes. This meant if you wanted alerts sent
to the dashboard and also a custom location, you weren't
able to do so with the template cephadm provided.

This also swaps to using "webhook_urls" instead of
"default_webhook_urls" for what should be in the spec,
but "default_webhook_urls" is kept working for backwards
compatability

Fixes: https://tracker.ceph.com/issues/68157
Signed-off-by: Adam King <adking@redhat.com>
doc/cephadm/services/monitoring.rst
src/pybind/mgr/cephadm/services/monitoring.py
src/pybind/mgr/cephadm/templates/services/alertmanager/alertmanager.yml.j2
src/pybind/mgr/cephadm/tests/test_services.py
src/python-common/ceph/deployment/service_spec.py