]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
cls/rgw: preserve olh entry's name on last unlink 36015/head
authorCasey Bodley <cbodley@redhat.com>
Fri, 10 Jul 2020 16:38:06 +0000 (12:38 -0400)
committerCasey Bodley <cbodley@redhat.com>
Fri, 10 Jul 2020 17:07:27 +0000 (13:07 -0400)
commitacf8f3cad9f55e34c703fdaef684853a3fb3b369
treef4ce6b26fb292b6c61d3b92b6f8c345b3385c584
parentae92ec82a723c6c67fea604925d95946dd4a3dbe
cls/rgw: preserve olh entry's name on last unlink

When rgw_bucket_unlink_instance removes the last instance of a name, it
also clears the value of rgw_bucket_olh_entry.key. However, bucket index
resharding uses this key when choosing its shard placement, so an empty
key causes all of these olh entries to be misplaced in shard 0. After
reshard, all of the olh recovery/cleanup logic would be sent to the
correct shard, and these misplaced olh entries would never be cleaned
up.

Preserving the key's name on last unlink allows the olh entry to be
resharded correctly and cleaned up normally.

Fixes: https://tracker.ceph.com/issues/46456
Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/cls/rgw/cls_rgw.cc