]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
test/librbd: correct expected_overlap in SnapshotCopyup 57163/head
authorIlya Dryomov <idryomov@gmail.com>
Tue, 30 Apr 2024 13:26:38 +0000 (15:26 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Tue, 30 Apr 2024 13:26:38 +0000 (15:26 +0200)
commitadee11c7969b23a56cd296d39bcb342cb003023a
treece2922b27b1c6a2aa471e6d9455d5c59f5663b54
parentb720f55ce8f0fbf741b369943d39ec844036c3c2
test/librbd: correct expected_overlap in SnapshotCopyup

Changing the end of second interval from 2096640 to copyup_end - 512
with copyup_end potentially set to 1 << order in commit 750e61ac91d7
("librbd: clone copy-on-write operations should preserve sparseness")
was incorrect because the test image size is just 2M.  There are no
end-to-end tests for enable_sparse_copyup = false case, so this went
unnoticed.

A year later, commit 38622b5ca12d ("librbd: copyup state machine
should always issue a sparse-read") dropped the respective branch in
CopyupRequest, thus eliminating the reason for branching on
enable_sparse_copyup altogether.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/test/librbd/test_internal.cc