]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: Fix pool update on edit 62869/head
authorAfreen Misbah <afreen@ibm.com>
Thu, 17 Apr 2025 15:35:39 +0000 (21:05 +0530)
committerAfreen Misbah <afreen@ibm.com>
Thu, 17 Apr 2025 15:35:39 +0000 (21:05 +0530)
commitaeeaf73507c28ef45de8773d0445bdc9eea3419c
tree00ac9fb8f6d0d49671f1b806f917a56bbac74851
parent3feb479d3bca488dfbe131f522a3e6dd19df363e
mgr/dashboard: Fix pool update on edit

Issue: Pool field was blank on editing namespace form and user needs to type out pool
Reason: `image` field is no longer supported in form yet edit function trying to fetch it and failing on that, hence no following updates for pool
Fix: Removed stale `image` field

Additional changes:
- included unit tests for edit to capture such errors
- enhanced unit tests to sue ActivatedRouteStub and `router.url`
- pre populating pool form on create with first rbd pool in the list

Fixes https://tracker.ceph.com/issues/70966

Regression by: https://tracker.ceph.com/issues/69900

Signed-off-by: Afreen Misbah <afreen@ibm.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts
src/pybind/mgr/dashboard/frontend/src/testing/activated-route-stub.ts