]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common/crc32c_intel_fast: avoid reading partial trailing word
authorSage Weil <sage@inktank.com>
Thu, 5 Sep 2013 04:29:11 +0000 (21:29 -0700)
committerSage Weil <sage@inktank.com>
Fri, 27 Sep 2013 17:55:41 +0000 (10:55 -0700)
commitb06c1898ea6913ae5e1e21fffc4b227a548f9b88
tree023e97730479cf1794961c115db8a66e19479827
parent5e3145a4d3ee50be6cb6542d2be192eb60fd6f8e
common/crc32c_intel_fast: avoid reading partial trailing word

The optimized intel code reads in word-sized chunks, knowing that the
allocator will only hand out memory in word-sized increments.   This makes
valgrind unhappy.  Whitelisting doesn't work because for some reason there
is no caller context (probably because of some interaction with yasm?).

Instead, just use the baseline code for the last few bytes.  This should
not be significant.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
(cherry picked from commit 39c89dcfed0587f822e2226f2de8e4092449af29)

Conflicts:
src/test/common/test_crc32c.cc
src/common/crc32c_intel_fast.c