]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
librbd: handle parent change while async I/Os are in flight
authorDan Mick <dan.mick@inktank.com>
Sat, 1 Dec 2012 02:11:09 +0000 (18:11 -0800)
committerDan Mick <dan.mick@inktank.com>
Thu, 6 Dec 2012 01:38:05 +0000 (17:38 -0800)
commitb2ccf11d3a108141f113f3f5640d459205f208f2
tree845fd3a06cb36d22f59ea65b4edb853e85d49ba3
parent64ecc87057a3214eef8528f3b937e1e8e3b1577d
librbd: handle parent change while async I/Os are in flight

During a test_librbd_fsx run including flatten, ImageCtx->parent
was being dereferenced while null.  Between the time the parent
overlap is calculated and the time the guard+write completes
with ENOENT and submits the copyup+write, the parent image
could have changed (by resize) or been made irrelevant (by
child flatten) such that the parent overlap is now incorrect.

Handle "no parent" by just sending the copyup+write; the copyup
part will be a no-op.  Move to WRITE_FLAT state in this case
because there's no more child to deal with.

Handle "overlap changed" by recalculating overlap before
reading parent data; if none is left, don't read, but rather
just clear m_object_image_extents, in which case the copyup
will again be a no-op because it will be of zero length.
However we still have a parent, so stay in WRITE_COPYUP state
and come back through as usual.

Signed-off-by: Dan Mick <dan.mick@inktank.com>
Fixes: #3524
(cherry picked from commit 41e16a3b40efb80a5ed7a5587438569ca86c85a3)
src/librbd/AioRequest.cc