]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mon: MDSMonitor: don't return -EINVAL if function is bool 3548/head
authorJoao Eduardo Luis <joao@redhat.com>
Fri, 17 Oct 2014 17:01:05 +0000 (18:01 +0100)
committerJoao Eduardo Luis <joao@redhat.com>
Wed, 4 Feb 2015 22:36:14 +0000 (22:36 +0000)
commitb318e2ffc3faedf6b02908429eb4ce79147d3471
tree982f74603d2e20ad887a916901ed2642d839140e
parenta1a7d856f5409280b6345afbbd961bcd8ee8d046
mon: MDSMonitor: don't return -EINVAL if function is bool

Returning -EINVAL on a function that expects bool and the error code to
be in a variable 'r' can only achieve one thing: if this path is ever
touched, instead of returning an error as it was supposed to, we're
returning 'true' with 'r = 0' and, for no apparent reason, the user will
think everything went smoothly but with no new fs created.

Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
(cherry picked from commit 91b2a2b69b198567d42f45f75b7f7ea559f89150)
src/mon/MDSMonitor.cc