]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
common/admin_socket: Copy fewer strings
authorAdam C. Emerson <aemerson@redhat.com>
Tue, 30 Jan 2018 04:27:33 +0000 (23:27 -0500)
committerAdam C. Emerson <aemerson@redhat.com>
Fri, 16 Feb 2018 17:41:41 +0000 (12:41 -0500)
commitbc9ab73704f7bc94e3a7fa0105936b340dde7478
tree418b823734cd8bf6718c6b19531797d21e06cd34
parente271ad9c781967b01c3f94a93216e099cfd73b36
common/admin_socket: Copy fewer strings

Pass std::string_view to call, rather than passing strings by value.

Change cmdmap_t and the maps in admin_socket to use the std::less<>
transparent comparator, so we can compare string_views to strings. (Or
anything else with an equality operator with strings.)

Pass the cmdmap_t in to call by const reference, not reference.

The change to cmdmap_t requires changing some of the users of
cmdmap_t. (That is, make them actually use cmdmap_t explicitly, not
the open-coed map type.)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
45 files changed:
src/client/Client.cc
src/client/Client.h
src/common/admin_socket.cc
src/common/admin_socket.h
src/common/ceph_context.cc
src/common/ceph_context.h
src/common/cmdparse.cc
src/common/cmdparse.h
src/librbd/LibrbdAdminSocketHook.cc
src/librbd/LibrbdAdminSocketHook.h
src/mds/MDSDaemon.cc
src/mds/MDSDaemon.h
src/mds/MDSRank.cc
src/mds/MDSRank.h
src/mgr/DaemonServer.cc
src/mgr/DaemonServer.h
src/mon/AuthMonitor.cc
src/mon/ConfigKeyService.cc
src/mon/FSCommands.cc
src/mon/FSCommands.h
src/mon/LogMonitor.cc
src/mon/MDSMonitor.cc
src/mon/MDSMonitor.h
src/mon/MgrMonitor.cc
src/mon/Monitor.cc
src/mon/Monitor.h
src/mon/MonmapMonitor.cc
src/mon/OSDMonitor.cc
src/mon/OSDMonitor.h
src/mon/PGMap.cc
src/mon/PGMap.h
src/osd/OSD.cc
src/osd/OSD.h
src/osdc/Objecter.cc
src/rgw/rgw_coroutine.cc
src/rgw/rgw_coroutine.h
src/rgw/rgw_rados.cc
src/rgw/rgw_rados.h
src/rgw/rgw_sync_trace.cc
src/rgw/rgw_sync_trace.h
src/test/admin_socket.cc
src/tools/rbd_mirror/ImageDeleter.cc
src/tools/rbd_mirror/ImageReplayer.cc
src/tools/rbd_mirror/Mirror.cc
src/tools/rbd_mirror/PoolReplayer.cc