]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS 54918/head
authorKefu Chai <tchaikov@gmail.com>
Fri, 15 Dec 2023 11:03:57 +0000 (19:03 +0800)
committerKefu Chai <tchaikov@gmail.com>
Fri, 15 Dec 2023 11:11:54 +0000 (19:11 +0800)
commitbeb1a624921d7589db63dea066935b3aa9ce2698
treeabcc51ba70274c4e6f3c847591346df8730d5e17
parent620b68a348f07145c49c12668576a89dee8198cb
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS

CMake allows us to customize `CMAKE_CXX_FLAGS` by setting CXXFLAGS
environmental variable. and Debian's debhelper also sets CXXFLAGS
when it builds cmake projects for customizing the building flags.

but we fail to populate this setting down when building external
projects. this is important when it comes to the projects which
is critical to the performance. RocksDB is one of them.

in this change, we pass the `CMAKE_CXX_FLAGS` down in
`BuildRocksDB.cmake` so that its `CMAKE_CXX_FLAGS` contains
the same set of `CMAKE_CXX_FLAGS` used by its parent project.

this should help with the performance in the bluestore, where
RocksDB is used.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
cmake/modules/BuildRocksDB.cmake