]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
crimson/os/seastore: use iter_cend()
authorKefu Chai <tchaikov@gmail.com>
Tue, 1 Mar 2022 16:08:48 +0000 (00:08 +0800)
committerKefu Chai <tchaikov@gmail.com>
Tue, 1 Mar 2022 16:58:25 +0000 (00:58 +0800)
commitc1039df60206cb7791a53d5ee65b1564ba9552ff
tree8cd3c28fa890971d786fd264e1320db2da738e20
parent9f4e1310214338b60b882d3266a3b89f1515f403
crimson/os/seastore: use iter_cend()

to avoid the pain of fixing the FTBFS with C++20 like

/var/ssd/ceph/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.cc:141:19: error: use of overloaded operator '!=' is ambiguous (with operand types 'crimson::os::seastore::omap_manager::StringKVInnerN$
  assert(child_pt != iter_end());
         ~~~~~~~~ ^  ~~~~~~~~~~
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^~~~
/var/ssd/ceph/src/crimson/os/seastore/omap_manager/btree/string_kv_node_layout.h:380:10: note: candidate function
    bool operator==(const iter_t &rhs) const {
         ^
/var/ssd/ceph/src/crimson/os/seastore/omap_manager/btree/string_kv_node_layout.h:380:10: note: candidate function (with reversed parameter order)

also, to be explicit is advisable.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/crimson/os/seastore/lba_manager/btree/lba_btree.cc
src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.cc