]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: still remove daemons in error state if ok-to-stop fails
authorAdam King <adking@redhat.com>
Fri, 28 Jul 2023 17:24:06 +0000 (13:24 -0400)
committerAdam King <adking@redhat.com>
Thu, 31 Aug 2023 17:36:14 +0000 (13:36 -0400)
commitc431e3af0fd947edafde8a5ac37fdeceb5c83515
treeddcef16921d8eac3681eb2a9b5bcf113df11a74a
parentafe55a397ac6266104f896eff957fd8c68730ad8
mgr/cephadm: still remove daemons in error state if ok-to-stop fails

The ok-to-stop function works for certain daemons
by checking if there are at least a certain number
(typically 1) daemon(s) that are actually running
and saying it's not ok-to-stop if if that won't
be true after the removals. This case breaks down
when all the daemons are in error state, making
it so cephadm will refuse to remove a set of
daemons that aren't even working because they're
not "ok to stop". Since ok-to-stop works in a
yes or no fashion, something like this where we
want to be willing to remove a certain subset
(or potentially all currently deployed) daemons
it's easier to keep this logic as part of applying
the service

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8bf99ba7b0862d7340690c74b6aa3ad995ae1098)
src/pybind/mgr/cephadm/serve.py