]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: fix http error checks in keystone/barbican/vault clients 53763/head
authorCasey Bodley <cbodley@redhat.com>
Thu, 5 Oct 2023 15:59:52 +0000 (11:59 -0400)
committerCasey Bodley <cbodley@redhat.com>
Wed, 11 Oct 2023 16:22:30 +0000 (12:22 -0400)
commitc58fbf182cd232687fb4fe3d83ef20599caf1531
tree2635722f0828ceb7616e3bd9d8ac093cd2173561
parentdc02c755b1ca2ba2d281052c77dd9e53d57f6cc3
rgw: fix http error checks in keystone/barbican/vault clients

when RGWHTTPManager encounters an http error, it uses
rgw_http_error_to_errno() to map that to a negative posix error code.
RGWHTTPClient::process() returns that mapped error code, and exposes the
original http error via get_http_status()

the http client code for keystone, barbican, and vault were returning
early on the errors from process(), so weren't getting to the http error
checks

these clients now check for specific http errors before testing the
result of process()

Fixes: https://tracker.ceph.com/issues/62989
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 36622e19c7fb217f32f74aada0d224785344f565)

Conflicts:
src/rgw/rgw_auth_keystone.cc null_yield
src/rgw/rgw_kms.cc null_yield
src/rgw/rgw_auth_keystone.cc
src/rgw/rgw_kms.cc