]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cls/fifo: Fix race condition on `_prepare_new_head`
authorAdam C. Emerson <aemerson@redhat.com>
Wed, 2 Nov 2022 02:49:12 +0000 (22:49 -0400)
committerAdam C. Emerson <aemerson@redhat.com>
Mon, 9 Jan 2023 22:49:40 +0000 (17:49 -0500)
commitccf7af6366e4f0d1170e95c8ba915e03a3898aba
treeaa82712d87d78feba9463bd0c34144c814a98b19
parentbe98337670a03f0fc2fbbb9eb955ea39fb610177
cls/fifo: Fix race condition on `_prepare_new_head`

First, make `_prepare_new_head` take the new head part number, so two
calls racing from the same push will attempt to create the same head.

Also remove the neorados FIFO since it doesn't have all the bug fixes
in the legacy version and will be rewritten in terms of `async_compose`
anyway.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit bf222906b01cbb9e8d55ae4685004a22cddcc138)
Conflicts:
src/rgw/cls_fifo_legacy.cc
 - Upstream C++20
Fixes: https://tracker.ceph.com/issues/58402
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
src/rgw/cls_fifo_legacy.cc
src/rgw/cls_fifo_legacy.h