]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
install.upgrade: fix overrides of sha1|tag|branch
authorSage Weil <sage@inktank.com>
Fri, 1 Nov 2013 17:56:42 +0000 (10:56 -0700)
committerSage Weil <sage@inktank.com>
Fri, 1 Nov 2013 17:56:42 +0000 (10:56 -0700)
commitd13c29cf506bb9f784aa304754e7189bec6f02e5
treed5757b1df474ee1d11d31444f59b710b0229778f
parented1d11ba9e45b2bdfb29bb93e60a2ffbfe86c8a3
install.upgrade: fix overrides of sha1|tag|branch

If the upgrade task config has a branch: (or tag or sha1), do
not apply the sha1|branch|tag overrides keys.  This fixes the
breakage from 280f783c2e8dda0df6afb4de0b115aad1614fbdc which
made

overrides:
  install:
    ceph:
      sha1: f88866fe9c218e03b3f89ff21e2b7b655aa74294
tasks:
...
- install.upgrade:
    all:
      branch: dumpling

...use the sha1 from the overrides instead of the explicitly
specified branch.  The intention was to only use the overrides
when the version was not specified (whether it was sha1 or
branch or tag).

At some point we should probably make the same change for
install function in install.py, but let's fix this first to
get the upgrade tests working.

Signed-off-by: Sage Weil <sage@inktank.com>
teuthology/task/install.py