]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
test_cls_version.cc: don't free object twice, free the right one
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Sat, 20 Jul 2013 17:36:32 +0000 (19:36 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Sat, 20 Jul 2013 17:43:29 +0000 (19:43 +0200)
commitd181aaaed45fcdf997d2cd1bf627d90ae643cff1
treec6dffe2d4dded01235c238881437cf807038dc15
parent11c51e84850335af0027bb9a859730427e758e4f
test_cls_version.cc: don't free object twice, free the right one

Object 'librados::ObjectWriteOperation *op' is freed twice in the TEST
test_version_inc_read. Free instead 'librados::ObjectReadOperation *rop'

Related cppcheck warning:
 [src/test/cls_version/test_cls_version.cc:79]: (error) Memory
  pointed to by 'op' is freed twice.

This should also fix:

CID 1049247 (#1 of 1): Use after free (USE_AFTER_FREE)
  deref_arg: Calling "librados::ObjectWriteOperation::~ObjectWriteOperation()"
  dereferences freed pointer "op". (The dereference happens because this is
  a virtual function call.)
CID 1049218 (#4 of 4): Resource leak (RESOURCE_LEAK)
  leaked_storage: Variable "rop" going out of scope leaks the storage it
  points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/test/cls_version/test_cls_version.cc