]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
messages/MForward: fix encoding features 11180/head
authorSage Weil <sage@redhat.com>
Wed, 28 Sep 2016 15:44:28 +0000 (11:44 -0400)
committerSage Weil <sage@redhat.com>
Wed, 28 Sep 2016 15:44:28 +0000 (11:44 -0400)
commitd4f5e88f36e5388ae9e062c4bc49ac1c684a3f3c
treee7347572748ebc92cfb02e0dc284753a2699788e
parentbca2d370caafd67400b32ca8b3a3d5f59a92adf6
messages/MForward: fix encoding features

We were encoding the message with the sending client's
features, which makes no sense: we need to encode with
the recipient's features so that it can decode the
message.

The simplest way to fix this is to rip out the bizarre
msg_bl handling code and simply keep a decoded Message
reference, and encode it when we send.

We encode the encapsulated message with the intersection
of the target mon's features and the sending client's
features.  This probably doesn't matter, but it's
conceivable that there is some feature-dependent
behavior in the message encode/decode that is important.

Fixes: http://tracker.ceph.com/issues/17365
Signed-off-by: Sage Weil <sage@redhat.com>
src/messages/MForward.h