]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS 55500/head
authorKefu Chai <tchaikov@gmail.com>
Fri, 15 Dec 2023 11:03:57 +0000 (19:03 +0800)
committerCasey Bodley <cbodley@redhat.com>
Thu, 8 Feb 2024 16:45:35 +0000 (11:45 -0500)
commitd81763bd32a869b3df475faa31f9befa9517ab8f
tree8b14bf7e30e89021a9c25ee4c8e09d643e175c1a
parent2d0f2674d43df98203e3890c1c2d6b05c904b498
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS

CMake allows us to customize `CMAKE_CXX_FLAGS` by setting CXXFLAGS
environmental variable. and Debian's debhelper also sets CXXFLAGS
when it builds cmake projects for customizing the building flags.

but we fail to populate this setting down when building external
projects. this is important when it comes to the projects which
is critical to the performance. RocksDB is one of them.

in this change, we pass the `CMAKE_CXX_FLAGS` down in
`BuildRocksDB.cmake` so that its `CMAKE_CXX_FLAGS` contains
the same set of `CMAKE_CXX_FLAGS` used by its parent project.

this should help with the performance in the bluestore, where
RocksDB is used.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit beb1a624921d7589db63dea066935b3aa9ce2698)
cmake/modules/BuildRocksDB.cmake