]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Revert "crimson/os/seastore: wait ool writes in DeviceSubmission phase" 59292/head
authorYingxin Cheng <yingxin.cheng@intel.com>
Mon, 19 Aug 2024 01:48:28 +0000 (09:48 +0800)
committerYingxin Cheng <yingxin.cheng@intel.com>
Mon, 19 Aug 2024 01:53:31 +0000 (09:53 +0800)
commitda6f3c4523d8cbb14718fef9f7c994d9253d7cd0
tree55eab02fcc917c6a23c855feaa581c11f91185e1
parent964adda23da9f7b057cb34fdc0b82aeb7ed65324
Revert "crimson/os/seastore: wait ool writes in DeviceSubmission phase"

This reverts commit c9e423facea79d42f0496264f267adee5d911b87.

The commit starts to submit OOL writes before submitting the journal
write, true, but it cannot guarantee that OOL writes finish before the
journal write.

Thus it is possible that during SeaStore restart, a journal record
appears valid but its dependent OOL records are partial written, which
leads to corruption.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
src/crimson/os/seastore/extent_placement_manager.cc
src/crimson/os/seastore/extent_placement_manager.h
src/crimson/os/seastore/journal/circular_bounded_journal.cc
src/crimson/os/seastore/journal/segmented_journal.cc
src/crimson/os/seastore/ordering_handle.h