]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw_cksum: address review comments
authorMatt Benjamin <mbenjamin@redhat.com>
Sat, 22 Jun 2024 20:12:54 +0000 (16:12 -0400)
committerMatt Benjamin <mbenjamin@redhat.com>
Wed, 3 Jul 2024 18:39:17 +0000 (14:39 -0400)
commitdc46e2778e3a47b038f7337d4e08d91451fcaa3e
tree2b05ddba38327e43881b8e25681c43c9b7b14c38
parentae4a871d3f3fff5f430d50952001ac273b2649fa
rgw_cksum: address review comments

* remove rgw_cksum_pipe state enum, not needed [Casey review]
* remove a format that just took a single string substitution
  and passed it to an iostream [Casey review]
* use boost::to_upper* [Casey review]
* remove unused RGW_ATTR_CKSUM_ALGORITHM decl [Casey review]
* negate error code values in two places [Casey review]
* split cksum digests from base type decls
* resolve comment when checksum requested but not available
* remove redundant memset
* remove junk from rgw_blake3_digest.h
* s/ldpp_dout + fmt::format/ldpp_dout_fmt/g;
* fix conditional return of parts_count
      from RGWRados::Object::prepare().  A value for parts_count should
      be returned iff a *multipart* object manifest exists.
* remove /tmp output test
* finish moving ceph_crypto headers out of rgw_cksum.h
* consume the optional in multipart_parts_count
* target_attrs can be a reference (but not const)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
src/rgw/driver/rados/rgw_rados.cc
src/rgw/rgw_blake3_digest.h
src/rgw/rgw_cksum.h
src/rgw/rgw_cksum_digest.h
src/rgw/rgw_cksum_pipe.cc
src/rgw/rgw_cksum_pipe.h
src/rgw/rgw_common.h
src/rgw/rgw_op.cc
src/rgw/rgw_rest_s3.cc
src/test/rgw/test_rgw_cksum.cc