]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/rbd_support: level_spec is optional for schedule list/status
authorIlya Dryomov <idryomov@gmail.com>
Sat, 29 Jan 2022 14:01:27 +0000 (15:01 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Sun, 6 Feb 2022 20:31:08 +0000 (21:31 +0100)
commite00fbecf62de9bb2facde10af19a82d98998983c
treefdb8a25cba620c5e455c53ee35eeea0bb8423128
parent268965289d9cc5c974e038c3826bad935bd3ed1e
mgr/rbd_support: level_spec is optional for schedule list/status

Commit fea6fdff4c74 ("mgr/rbd_support: level_spec passed to some
commands is not optional") is wrong.  While it is true that a valid
level_spec is needed to create a LevelSpec instance, an empty string
is very much a valid level spec -- it signifies "all levels".

This wasn't caught because within Ceph these commands are wrapped by
rbd CLI which injects an empty string in get_level_spec_args().

Fixes: https://tracker.ceph.com/issues/54058
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit a5eef01e9248b09c187fcb8c6d122fd08dc54c88)
qa/workunits/rbd/cli_generic.sh
src/pybind/mgr/rbd_support/module.py