]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
messages/MForward: fix encoding features
authorSage Weil <sage@redhat.com>
Wed, 28 Sep 2016 15:44:28 +0000 (11:44 -0400)
committerKefu Chai <kchai@redhat.com>
Wed, 2 Nov 2016 11:23:24 +0000 (19:23 +0800)
commite068c9206a3d618b3b04975d03f61ca64a92c4d4
treeabec4fff32d51d3dbd71bea3eb3c17e2b66c85fb
parent158b003751d8bedafdca60d859aef67e69d9a732
messages/MForward: fix encoding features

We were encoding the message with the sending client's
features, which makes no sense: we need to encode with
the recipient's features so that it can decode the
message.

The simplest way to fix this is to rip out the bizarre
msg_bl handling code and simply keep a decoded Message
reference, and encode it when we send.

We encode the encapsulated message with the intersection
of the target mon's features and the sending client's
features.  This probably doesn't matter, but it's
conceivable that there is some feature-dependent
behavior in the message encode/decode that is important.

Fixes: http://tracker.ceph.com/issues/17365
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit d4f5e88f36e5388ae9e062c4bc49ac1c684a3f3c)
src/messages/MForward.h