]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rbd: find_action() should sort actions first
authorIlya Dryomov <idryomov@gmail.com>
Fri, 12 Aug 2022 09:10:45 +0000 (11:10 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 12 Aug 2022 09:10:45 +0000 (11:10 +0200)
commite0b428a87a48f2132c825ffde4629709a57b76d6
tree5fa1014b80893f83a7465f08af2484cd61952daf
parent5ab5ff46d6d799c46d8a1c01cc08068a22e4c9b5
rbd: find_action() should sort actions first

The order in which objects with static storage duration in
different TUs are initialized is undefined.  If the compiler
chooses to initialize Shell::Action objects in action/Trash.cc
before Shell::Action objects in action/TrashPurgeSchedule.cc,
all "rbd trash purge schedule ..." commands get shadowed by
"rbd trash purge" command:

$ rbd trash purge schedule list
rbd: too many arguments

The confusing error arises because "rbd trash purge" takes a single
positional argument.  "schedule" gets interpreted as <pool-spec> and
"list" generates an error.

Fixes: https://tracker.ceph.com/issues/57107
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/tools/rbd/Shell.cc