]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/rbd_support: always parse interval and start_time in Schedules::remove() 62964/head
authorIlya Dryomov <idryomov@gmail.com>
Tue, 25 Mar 2025 08:13:27 +0000 (09:13 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 25 Apr 2025 07:17:09 +0000 (09:17 +0200)
commite616e42e2742b7b28796918742cfd847738cda02
treea371b241972a6345c870d6710c3c850afbc69b3f
parentaa395e6f08e1523b2ffbdfcbb547af179e491d74
mgr/rbd_support: always parse interval and start_time in Schedules::remove()

Commit 1b62447071a9 ("mgr/rbd_support: fix schedule remove") addressed
the issue that it was concerned with in a rather suboptimal way: instead
of moving the parsing of interval and start_time upfront to be able to
bail early, it wrapped from_string() constructors with try/finally and
left the conditional behavior in place.

Fixes: https://tracker.ceph.com/issues/70640
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bcd676356231c97c8275e6c03becc2c58497f20d)
qa/workunits/rbd/cli_generic.sh
src/pybind/mgr/rbd_support/schedule.py