]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
ceph.in: check ceph-conf returncode 30695/head
authorDimitri Savineau <dsavinea@redhat.com>
Wed, 2 Oct 2019 14:52:40 +0000 (10:52 -0400)
committerDimitri Savineau <dsavinea@redhat.com>
Mon, 7 Oct 2019 13:12:09 +0000 (09:12 -0400)
commite69aea66ea5ba941e25eb42508e43e4670820cbd
treec941c70ba535301bf263f941bba97504c3942f6c
parent20c8007c265c4aeb10cdb9d7b9b119c232ba33ed
ceph.in: check ceph-conf returncode

When running the ceph-conf command, we only check the stderr output. When
the ceph configuration file has duplicate values then the ceph daemon
command will fail because the stderr will contain the warning message but
the ceph-conf return code is 0.

$ ceph-conf --name mon.cephaio-1 --show-config-value admin_socket
warning: line 13: 'osd_memory_target' in section 'osd' redefined
/var/run/ceph/ceph-mon.cephaio-1.asok
$ echo $?
0

Fixes: https://tracker.ceph.com/issues/37664
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
src/ceph.in