]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
qa/cephfs: don't inherit CephFSTestCase in CapTester
authorRishabh Dave <ridave@redhat.com>
Thu, 13 Apr 2023 19:08:33 +0000 (00:38 +0530)
committerRishabh Dave <ridave@redhat.com>
Tue, 18 Apr 2023 14:04:40 +0000 (19:34 +0530)
commite8bdf94b814eb09f859e6d1e31d53e826a7bffcc
treef8af0e11d7cf5414f3c34304aa556d4ed2cb0120
parent1a7ca489b4b84ae48c831ec63b201c024047b295
qa/cephfs: don't inherit CephFSTestCase in CapTester

Inheritting CephFSTestCase in CapTester just for methods assertEqual()
and assertIn() from class unittest.TestCase is odd and heavy-weight.
Don't inherit CephFSTestCase and use simple assert instead.

Reference: https://github.com/ceph/ceph/pull/50882#discussion_r1160611549.

To avoid code duplication, a couple of similar methods have been added
instead.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/cephfs/caps_helper.py