]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c42a102) | patch
rbd-mirror: straighten ImageReplayer::stop() a bit
authorIlya Dryomov <idryomov@gmail.com>
Sat, 19 Feb 2022 15:43:04 +0000 (16:43 +0100)
committerDeepika Upadhyay <dupadhya@redhat.com>
Sat, 26 Feb 2022 19:13:50 +0000 (00:43 +0530)
commitea61a3e26a386ddfb9a79475b70aa0f689d56610
tree11ae21edaff88cf19e88f0a87fad69f08686a363tree | snapshot
parentc42a10239a4c0d70677bb99dfd0fe2d910016c8acommit | diff
rbd-mirror: straighten ImageReplayer::stop() a bit

- don't default on_finish parameter
- m_restart_requested is set in ImageReplayer::restart() which is the
  only restart=true call site, so setting m_restart_requested here is
  redundant
- is_stopped_() can't be true in is_running_() branch
- on_finish->complete(0) in the end is unreachable

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 219c500977bbfbcfe4ccd24beb294edbe0562d35)
src/test/rbd_mirror/test_mock_ImageReplayer.cc diff | blob | history
src/tools/rbd_mirror/ImageReplayer.cc diff | blob | history
src/tools/rbd_mirror/ImageReplayer.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.