]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
Revert "osd/PGLog.cc: Trim duplicates by number of entries"
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 21:22:29 +0000 (21:22 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 21:22:29 +0000 (21:22 +0000)
commitea7429d37fb947e3390d55eead90ad8f50dd67d6
treedbbf3c1fba921a454a01a6d44a00b697100e1468
parentc1e0109d2cf2fae3715433650efbfd8b7ddfceaf
Revert "osd/PGLog.cc: Trim duplicates by number of entries"

This reverts commit d49ff13c80bbed5fb6c064f9689bb2b6a0a251b8.
which is the in-OSD part of the fix for accumulation of `dup`
entries in a PG Log. Brainstorming it has brought questions
on the OSD's behaviour during an upgrade if there are tons of
dups in the log. What must be double-checked before bringing
it back is ensuring we chunk the deletions properly to not
impose OOMs / stalls in, to exemplify, RocksDB.

The backport ticket is: https://tracker.ceph.com/issues/55989

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/osd/PGLog.cc
src/osd/PGLog.h
src/test/osd/TestPGLog.cc
src/tools/ceph_objectstore_tool.cc