]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
dmclock/.../dmclock_server: do not clean clients with requests 62363/head
authorSamuel Just <sjust@redhat.com>
Thu, 13 Feb 2025 04:16:47 +0000 (04:16 +0000)
committerSamuel Just <sjust@redhat.com>
Tue, 18 Mar 2025 17:39:10 +0000 (17:39 +0000)
commitef4f0d5369e85209da5b18a3ad5ee0177590018d
treeffb7c0ec5e3b976d8825cbc34094c7bdce2d717a
parentf8f993671bcdc283298d31a7eb9e52715bf874b0
dmclock/.../dmclock_server: do not clean clients with requests

PriorityQueueBase::do_clean() shouldn't remove ClientRec instances which
still have queued requests.  Otherwise, very low priority clients might
end up having requests actually lost, which shouldn't be possible.

In the OSD, this resulted in PGRecovery items being lost if queued with
background_best_effort while expanding a cluster.  Such items can
legitimately sit in the queue for a long period of time as they
represent background data migration which is allowed to be starved by an
aggressive client workload.  Dropping the items broke an assumption in
the OSD that all items enqueued would eventually be dequeued resulting
in resources being leaked.

Fixes: https://tracker.ceph.com/issues/61594
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 35cf0f6c1355ff420c431340ac36d9a3c029d6c2)
src/dmclock/src/dmclock_server.h