]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 53eb841) | patch
mgr/dashboard: fix exception in get_smart_data_by_daemon 37972/head
authorKiefer Chang <kiefer.chang@suse.com>
Wed, 18 Nov 2020 11:35:02 +0000 (19:35 +0800)
committerLaura Paduano <lpaduano@suse.com>
Wed, 3 Feb 2021 14:43:27 +0000 (15:43 +0100)
commitf13127daf8a0f2852f5b30435d7666ff1a210d9d
treec5556fe85acdabe8f9a07521c5393ef5d61da9a2tree | snapshot
parent53eb841a0a367c5e2d48dc0ad9a83f38b562bbd8commit | diff
mgr/dashboard: fix exception in get_smart_data_by_daemon

- Fix string substitution exception.
- Add more test coverage.

Fixes: https://tracker.ceph.com/issues/48245
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit d2ddea5a79a54086c4ee104aea4f59f10d174735)

 Conflicts:
src/pybind/mgr/dashboard/requirements-lint.txt
src/pybind/mgr/dashboard/tests/test_ceph_service.py
 - Added pytest; fixed and re-arranged imports; removed isort
   since it breaks make check in octopus
src/pybind/mgr/dashboard/requirements-lint.txt diff | blob | history
src/pybind/mgr/dashboard/services/ceph_service.py diff | blob | history
src/pybind/mgr/dashboard/tests/test_ceph_service.py diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.