]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
common/pick_address: prefer non-loopback addresses
authorKefu Chai <kchai@redhat.com>
Wed, 21 Apr 2021 11:50:48 +0000 (19:50 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 13 May 2021 01:25:33 +0000 (09:25 +0800)
commitf280ac04c8a8358fd8a161bf84058442eb1578c0
tree6ae05ebc2f6409c1b4aeebde5e1aac61fa59264d
parent56385b8767557b50f97dc82c3b4f1d89a32701bc
common/pick_address: prefer non-loopback addresses

instead of filtering out loopback ifaces, check for loopback addresses,
and prefer non-loopback addresses over loopback addresses.

before this change, iface named "lo" is filtered out by default,
and "lo" is allowed if `ms_bind_exclude_lo_iface` is false.

after this change, iface with address out of 127/8 is prefered.
the iface marked down is not considered.

the option of "ms_bind_exclude_lo_iface" is removed. the tests are
updated accordingly.

Fixes: https://tracker.ceph.com/issues/50456
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit a9b9bcd53215a07608a28ac2c8e4a8c8b8e80e66)

Conflicts:
src/common/options/global.yaml.in
src/common/pick_address.cc: trivial resolution
src/common/options.cc
src/common/pick_address.cc
src/common/pick_address.h
src/test/test_ipaddr.cc