]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crimson/common: add alternative overload for FixedKVNodeLayout<>::iter_t
authorKefu Chai <tchaikov@gmail.com>
Mon, 28 Feb 2022 15:12:22 +0000 (23:12 +0800)
committerKefu Chai <tchaikov@gmail.com>
Sat, 30 Jul 2022 05:02:15 +0000 (13:02 +0800)
commitf7e122e4b8f671e0555855c0a53d9f748a35dcfb
tree307c3d2a5f8c56400a93482ce7f6cab7f2d83bf8
parent610c0d51110e139237a412f9c07d11378d503bee
crimson/common: add alternative overload for FixedKVNodeLayout<>::iter_t

otherwise we'd have following FTBFS with C++20 and clang13:

In file included from /var/ssd/ceph/src/crimson/os/seastore/lba_manager.cc:7:
In file included from /var/ssd/ceph/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h:24:
/var/ssd/ceph/src/crimson/os/seastore/lba_manager/btree/lba_btree.h:474:26: error: use of overloaded operator '==' is ambiguous (with operand types 'crimson::common::FixedKVNodeLayout<254, crimson::os::seastore::l$
    auto end = next_iter == parent->end()
               ~~~~~~~~~ ^  ~~~~~~~~~~~~~
/var/ssd/ceph/src/crimson/common/fixed_kv_node_layout.h:127:10: note: candidate function
    bool operator==(const iter_t &rhs) const {
         ^
/var/ssd/ceph/src/crimson/common/fixed_kv_node_layout.h:127:10: note: candidate function (with reversed parameter order)

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/crimson/common/fixed_kv_node_layout.h