]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
Revert "os/bluestore: add kv_drain_preceding_waiters indicate drain_preceding." 31503/head
authorSage Weil <sage@redhat.com>
Fri, 8 Nov 2019 23:29:03 +0000 (17:29 -0600)
committerSage Weil <sage@redhat.com>
Fri, 8 Nov 2019 23:30:54 +0000 (17:30 -0600)
commitf97a7dcfe7b3c4013d2bf0524dd5852be4bc6c07
tree572dabc99075805f3594883c7f39ba3a8bec52bb
parent25e26d27cf1d18c025a717b3adeaff12c8df41a4
Revert "os/bluestore: add kv_drain_preceding_waiters indicate drain_preceding."

This reverts commit ff71ad472e94e14f392c618b6eb5e8608afec94f.

This change has two problems:

1- First, we want to be aggressive about deferred IO so that we don't have
to wait very long for things to flush.

2- Because we aren't aggressive, when the deferred io does finish, the kv
thread isn't woken back up, which means we hang.

More generally, I don't think we care about making aggressive mode avoid
wakeups, because it is exceedingly rare--it only happens when we are
splitting PGs.

Fixes: https://tracker.ceph.com/issues/42712
Signed-off-by: Sage Weil <sage@redhat.com>
src/os/bluestore/BlueStore.cc
src/os/bluestore/BlueStore.h