]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mds: ignore unknown client op when tracking op latency 44976/head
authorVenky Shankar <vshankar@redhat.com>
Mon, 13 Dec 2021 06:15:19 +0000 (01:15 -0500)
committerVenky Shankar <vshankar@redhat.com>
Thu, 10 Feb 2022 12:45:18 +0000 (18:15 +0530)
commitfec74f1d8874c17fab820f3a3cc92c6b46d1e0cc
tree44e469cebf85c11f53f6b75603c09c3b2ca86382
parent541b3b9b7d1ac8b72c10f785bed4dc043b5d7c8d
mds: ignore unknown client op when tracking op latency

Server::handle_client_request() ignores unknown client operation
by returning -ENOTSUPP, however, Server::perf_gather_op_latency()
aborts on unknown client op, thereby causing -ENOTSUPP to never
reach the client. ceph_abort() seems unnecessary here.

Note, we could have invoked Server::perf_gather_op_latency()
when the return value to client is not -ENOTSUPP, however,
a valid client operation *might* just return -ENOTSUPP in
some cases.

@mchangir ran into this with his getvxattr op changes (PR #42001).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 2f4060b8c41004d10d9a64676ccd847f6e1304dd)
src/mds/Server.cc